Merge branch 'main' into fix/8714

withastro · Jan 31, 2024 · 5fc371e · 5fc371e
2 parents 4d4eaa7 + aaedb84
commit 5fc371e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/tiny-moose-melt.md b/.changeset/tiny-moose-melt.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes an issue where some adapters that do not include a `start()` export would error rather than silently proceed
diff --git a/packages/astro/src/core/build/plugins/plugin-ssr.ts b/packages/astro/src/core/build/plugins/plugin-ssr.ts
@@ -263,7 +263,14 @@ function generateSSRCode(adapter: AstroAdapter, middlewareId: string) {
 				return `export const ${name} = _exports['${name}'];`;
 			}
 		}) ?? []),
-		`serverEntrypointModule.start?.(_manifest, _args);`,
+		// NOTE: This is intentionally obfuscated!
+		// Do NOT simplify this to something like `serverEntrypointModule.start?.(_manifest, _args)`
+		// They are NOT equivalent! Some bundlers will throw if `start` is not exported, but we
+		// only want to silently ignore it... hence the dynamic, obfuscated weirdness.
+		`const _start = 'start';
+if (_start in serverEntrypointModule) {
+	serverEntrypointModule[_start](_manifest, _args);
+}`,
 	];
 
 	return {