-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Better response.arrayBuffer() handling in Node
- Loading branch information
Showing
7 changed files
with
120 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { defineConfig } from 'astro/config'; | ||
| import solid from '@astrojs/solid-js'; | ||
|
|
||
| // https://astro.build/config | ||
| export default defineConfig({ | ||
| integrations: [solid()], | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "name": "@test/large-array-solid", | ||
| "version": "0.0.0", | ||
| "private": true, | ||
| "dependencies": { | ||
| "@astrojs/solid-js": "workspace:*", | ||
| "astro": "workspace:*" | ||
| } | ||
| } |
18 changes: 18 additions & 0 deletions
18
packages/astro/test/fixtures/large-array/src/components/Counter.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { createSignal } from 'solid-js'; | ||
|
|
||
| export default function Counter({ children, largeProp }) { | ||
| const [count, setCount] = createSignal(0); | ||
| const add = () => setCount(count() + 1); | ||
| const subtract = () => setCount(count() - 1); | ||
|
|
||
| return ( | ||
| <> | ||
| <div class="counter"> | ||
| <button onClick={subtract}>-</button> | ||
| <pre>{count()}</pre> | ||
| <button onClick={add}>+</button> | ||
| </div> | ||
| <div class="counter-message">{children}</div> | ||
| </> | ||
| ); | ||
| } |
32 changes: 32 additions & 0 deletions
32
packages/astro/test/fixtures/large-array/src/pages/index.astro
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| --- | ||
| import Counter from '../components/Counter.jsx'; | ||
| const largeArray = [] | ||
| for (let i = 0; i < 600; i++) { | ||
| largeArray.push({ a: 'abc', b: 'abc', c: 'abc', d: 'abc', e: 'abc', foo: 'bar' }) | ||
| } | ||
| --- | ||
|
|
||
| <html> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width" /> | ||
| <link rel="icon" type="image/x-icon" href="/favicon.ico" /> | ||
| <style> | ||
| html, | ||
| body { | ||
| font-family: system-ui; | ||
| margin: 0; | ||
| } | ||
| body { | ||
| padding: 2rem; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <main> | ||
| <Counter client:visible largeProp={largeArray}> | ||
| <h1>Hello, Solid!</h1> | ||
| </Counter> | ||
| </main> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { expect } from 'chai'; | ||
| import * as cheerio from 'cheerio'; | ||
| import { loadFixture } from './test-utils.js'; | ||
| import testAdapter from './test-adapter.js'; | ||
|
|
||
| describe('SSR with Large Array and client rendering', () => { | ||
| /** @type {import('./test-utils').Fixture} */ | ||
| let fixture; | ||
|
|
||
| before(async () => { | ||
| fixture = await loadFixture({ | ||
| root: './fixtures/large-array/', | ||
| experimental: { | ||
| ssr: true, | ||
| }, | ||
| adapter: testAdapter(), | ||
| }); | ||
| await fixture.build(); | ||
| }); | ||
|
|
||
| it('Using response.arrayBuffer() gets the right HTML', async () => { | ||
| const app = await fixture.loadTestAdapterApp(); | ||
| const request = new Request('http://example.com/'); | ||
| const response = await app.render(request); | ||
| const data = await response.arrayBuffer(); | ||
| const html = new TextDecoder().decode(data); | ||
|
|
||
| const $ = cheerio.load(html); | ||
| expect($('head meta[name="viewport"]')).to.have.a.lengthOf(1); | ||
| expect($('head link[rel="icon"]')).to.have.a.lengthOf(1); | ||
| expect($('main')).to.have.a.lengthOf(1); | ||
| expect($('astro-island')).to.have.a.lengthOf(1); | ||
| expect($('h1').text()).to.equal('Hello, Solid!'); | ||
| }); | ||
| }); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.