chore: changeset (#3873)

withastro · Jul 8, 2022 · 957fb50 · 957fb50
1 parent f9ed77b
commit 957fb50
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/quiet-pugs-tie.md b/.changeset/quiet-pugs-tie.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fix hydration for SSR components that return null
diff --git a/packages/astro/src/runtime/server/astro-island.ts b/packages/astro/src/runtime/server/astro-island.ts
@@ -42,7 +42,7 @@ declare const Astro: {
 				public hydrator: any;
 				static observedAttributes = ['props'];
 				connectedCallback() {
-					if (this.getAttribute('client') === 'only' || this.firstChild) {
+					if (!this.getAttribute('await-children') || this.firstChild) {
 						this.childrenConnectedCallback();
 					} else {
 						// connectedCallback may run *before* children are rendered (ex. HTML streaming)

diff --git a/packages/astro/src/runtime/server/index.ts b/packages/astro/src/runtime/server/index.ts
@@ -452,6 +452,10 @@ If you're still stuck, please open an issue on GitHub or join us at https://astr
 
 	island.children = `${html ?? ''}${template}`;
 
+	if (island.children) {
+		island.props['await-children'] = ''
+	}
+
 	// Scripts to prepend
 	let prescriptType: PrescriptType = needsHydrationScript
 		? 'both'