Fixing TypeScript type definitions for image components (#3980)

* moving back to importing from components directory * exporting components with a .ts file instead of .js * chore: changeset
withastro · Jul 20, 2022 · eaf187f · eaf187f
1 parent b043fb1
commit eaf187f
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 7 deletions.
diff --git a/.changeset/perfect-islands-teach.md b/.changeset/perfect-islands-teach.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/image': patch
+---
+
+Fixing TypeScript definition exports for image components
diff --git a/packages/integrations/image/README.md b/packages/integrations/image/README.md
@@ -104,7 +104,7 @@ export default {
 
 ```html
 ---
-import { Image } from '@astrojs/image';
+import { Image } from '@astrojs/image/components';
 import heroImage from '../assets/hero.png';
 ---
 
@@ -132,7 +132,7 @@ import heroImage from '../assets/hero.png';
 
 ```html
 ---
-import { Image } from '@astrojs/image';
+import { Image } from '@astrojs/image/components';
 
 const imageUrl = 'https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png';
 ---
@@ -156,7 +156,7 @@ const imageUrl = 'https://www.google.com/images/branding/googlelogo/2x/googlelog
 ```html
 ---
 setup: |
-  import { Image } from '@astrojs/image'
+  import { Image } from '@astrojs/image/components'
   import hero from '../../assets/blog/introducing-astro.jpg'
 title: Hello world!
 publishDate: 12 Sep 2021
@@ -181,7 +181,7 @@ description: Just a Hello World Post!
 
 ```html
 ---
-import { Picture } from '@astrojs/image';
+import { Picture } from '@astrojs/image/components';
 import hero from '../assets/hero.png';
 
 const imageUrl = 'https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png';

diff --git a/...es/integrations/image/components/index.js → ...es/integrations/image/components/index.ts b/...es/integrations/image/components/index.js → ...es/integrations/image/components/index.ts
diff --git a/packages/integrations/image/src/types.ts b/packages/integrations/image/src/types.ts
@@ -1,5 +1,4 @@
 /// <reference types="astro/astro-jsx" />
-export type { Image, Picture } from '../components/index.js';
 export * from './index.js';
 
 interface ImageIntegration {

diff --git a/packages/integrations/image/test/fixtures/basic-image/src/pages/index.astro b/packages/integrations/image/test/fixtures/basic-image/src/pages/index.astro
@@ -1,6 +1,6 @@
 ---
 import socialJpg from '../assets/social.jpg';
-import { Image } from '@astrojs/image';
+import { Image } from '@astrojs/image/components';
 ---
 
 <html>

diff --git a/packages/integrations/image/test/fixtures/basic-picture/src/pages/index.astro b/packages/integrations/image/test/fixtures/basic-picture/src/pages/index.astro
@@ -1,6 +1,6 @@
 ---
 import socialJpg from '../assets/social.jpg';
-import { Picture } from '@astrojs/image';
+import { Picture } from '@astrojs/image/components';
 ---
 
 <html>