Skip to content

Commit

Permalink
Adds closedby to dialog interface (#12728)
Browse files Browse the repository at this point in the history
* Adds `closedby` to dialog interface

Standards status https://chromestatus.com/feature/5097714453577728

* Add changeset

---------

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
  • Loading branch information
argyleink and delucis authored Dec 13, 2024
1 parent 72f30dd commit ee66a45
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/neat-pumas-accept.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": patch
---

Adds type support for the `closedby` attribute for `<dialog>` elements
1 change: 1 addition & 0 deletions packages/astro/astro-jsx.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,7 @@ declare namespace astroHTML.JSX {

interface DialogHTMLAttributes extends HTMLAttributes {
open?: boolean | string | undefined | null;
closedby?: 'none' | 'closerequest' | 'any' | undefined | null;
}

interface EmbedHTMLAttributes extends HTMLAttributes {
Expand Down

0 comments on commit ee66a45

Please sign in to comment.