Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@astrojs/image] the Squoosh service defaults to too high a quality setting, creating larger built files #4905

Closed
1 task done
tony-sull opened this issue Sep 28, 2022 · 0 comments · Fixed by #4906
Closed
1 task done

[@astrojs/image] the Squoosh service defaults to too high a quality setting, creating larger built files #4905

tony-sull opened this issue Sep 28, 2022 · 0 comments · Fixed by #4906
Assignees
@tony-sull
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) pkg: image Related to the `@astrojs/image` package (scope)

Comments

@tony-sull
Copy link
Contributor

tony-sull commented Sep 28, 2022 •
edited
Loading

What version of astro are you using?

1.3.1

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

pnpm

What operating system are you using?

Mac

Describe the Bug

When using the new Squoosh image service, if a quality isn't passed to the image component it's being default to 100. Interestingly enough this leads to files getting larger when they're built 🙃

The defaults are already tied into the Squoosh implementation, we should just need to remove our quality = 100 default

Link to Minimal Reproducible Example

https://discord.com/channels/830184174198718474/1024553095771979860

Participation

  • I am willing to submit a pull request for this issue.
@tony-sull tony-sull added - P4: important Violate documented behavior or significantly impacts performance (priority) s1-small pkg: image Related to the `@astrojs/image` package (scope) labels Sep 28, 2022
@tony-sull tony-sull self-assigned this Sep 28, 2022
@tony-sull tony-sull mentioned this issue Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tony-sull tony-sull

Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) pkg: image Related to the `@astrojs/image` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: let Squoosh default image quality internally withastro/astro
1 participant
@tony-sull