Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404.astro not rendering 404.html when there are dynamic routes in the root directory #7301

Closed
1 task
hongfanmeng opened this issue Jun 6, 2023 · 3 comments · Fixed by #7693
Closed
1 task

404.astro not rendering 404.html when there are dynamic routes in the root directory #7301

hongfanmeng opened this issue Jun 6, 2023 · 3 comments · Fixed by #7693
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)

Comments

@hongfanmeng
Copy link

What version of astro are you using?

2.5.0

Are you using an SSR adapter? If so, which one?

Cloudflare

What package manager are you using?

pnpm

What operating system are you using?

Linux

What browser are you using?

Chrome

Describe the Bug

404.astro not rendering 404.html when there are dynamic routes in the root directory

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-nhc9gb?file=src%2Fpages%2F404.astro

Participation

  • I am willing to submit a pull request for this issue.
@proyb6
Copy link

proyb6 commented Jun 6, 2023

Hi there, this issue has been filed twice too.

@arpadgabor
Copy link

Experiencing this too.

@bholmesdev bholmesdev added the - P3: minor bug An edge case that only affects very specific usage (priority) label Jun 12, 2023
@bholmesdev bholmesdev mentioned this issue Jun 12, 2023
Closed
1 task
@bholmesdev bholmesdev added - P4: important Violate documented behavior or significantly impacts performance (priority) and removed - P3: minor bug An edge case that only affects very specific usage (priority) labels Jun 12, 2023
natemoo-re added a commit that referenced this issue Jul 17, 2023
@natemoo-re
fix(#7301): load 404 page in dev server when returning 404 status code
60c8165
@natemoo-re natemoo-re mentioned this issue Jul 17, 2023
Merged
natemoo-re added a commit that referenced this issue Jul 18, 2023
@natemoo-re
Fix 404 handling in dev server (#7693)
d401866 
* fix(#7301): load 404 page in dev server when returning 404 status code

* chore: add changeset

* fix(404): expose exact pathname/URL when rendering 404

* test: add custom-404-server test
@proyb6
Copy link

proyb6 commented Jul 19, 2023

Finally! Found 404 page not found after the fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 404 handling in dev server withastro/astro
4 participants
@arpadgabor @proyb6 @hongfanmeng @bholmesdev