fix(i18n): make i18n.routing fields optional

[ematipico]

Changes

Addresses the typing issue of #10157

The properties inside i18n.routing were incorrectly typed. Now they are optional.

The type of domains was placed in the wrong part of the config... ooops! I fixed that too

Testing

It should compile and current tests should pass

Docs

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: d8154be

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Princesseuh]

Looks fine to me!

[delucis]

How was this tested? .default() marks a field as optional already so this wouldn't change anything I don't think? I think the issue I noticed with types might come from the manual types file not the schema?

[ematipico]

How was this tested? .default() marks a field as optional already so this wouldn't change anything I don't think? I think the issue I noticed with types might come from the manual types file not the schema?

Turns out, it does not, unless that's a bug in zod. The current changes aren't woking. Doing prefixDefaultLocale: z.boolean().optional().default(false), emits a prefixDefaultLocale: boolean, while prefixDefaultLocale: z.boolean().optional() emits a prefixDefaultLocale?: boolean | undefined.

The thing is, we need a default value.

[ematipico]

Totally forgot that astro.config doesn't use the schema, but it uses astro.d.ts. I changed the types there and it works like a charm now. I used a pet project to test it

cc @delucis @Princesseuh

[delucis]

The @types/astro.ts changes look good! (Although there’s an indentation change I guess the auto-formatter will revert?)

Left a suggestion to remove the unnecessary .optional()s in the schema.

[delucis]

Thanks for tackling this so quickly @ematipico!

[Princesseuh]

I always forget how the types for the config interact too, oops.