Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] update lockfile #10234

Merged
merged 6 commits into from
Mar 13, 2024
Merged

[ci] update lockfile #10234

merged 6 commits into from
Mar 13, 2024

Conversation

astrobot-houston
Copy link
Contributor

This PR is auto-generated by a nightly GitHub action. It should automatically be merged if tests pass.

Copy link

changeset-bot bot commented Feb 26, 2024

⚠️ No Changeset found

Latest commit: 3c9db33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bluwy
Copy link
Member

bluwy commented Feb 26, 2024

I tried fixing the errors, but we're block on the same issue as #8762 (comment) again. It's erroring about the RemarkRehype type, but this time it's erroring to include a remark-rehype/lib/index.js which is impossible for us to include because it's not exported.

I'm not really sure how to go here besides downgrading it for now, but I think we should re-think how we infer the schema types as it has caused many problems. Maybe we should manually type it.

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 12, 2024
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 12, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging with approval from Erika on Discord. I've figured out a workaround to fix the schema types issue, so we could remove the transitive dependency and use the types as usual.

@bluwy bluwy merged commit b3dbb49 into main Mar 13, 2024
2 checks passed
@bluwy bluwy deleted the ci/lockfile branch March 13, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants