Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[db] Add success=false handling to API entrypoints #10387

Merged
merged 1 commit into from
Mar 11, 2024
Merged

[db] Add success=false handling to API entrypoints #10387

merged 1 commit into from
Mar 11, 2024

Conversation

FredKSchott
Copy link
Member

Changes

  • We had an issue where the server was incorrectly returning a 200 on error responses.
  • This is a bit redundant if everything is working well, but a good line of defense in case anything isn't.

Testing

  • n/a

Docs

  • n/a

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 571c742

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FredKSchott FredKSchott changed the title Add success fail handling [db] Add success=false handling to API entrypoints Mar 11, 2024
@FredKSchott FredKSchott force-pushed the add-success-fail-handling branch from 1ce835c to da04e9b Compare March 11, 2024 16:36
@FredKSchott FredKSchott force-pushed the add-success-fail-handling branch from da04e9b to 6260e47 Compare March 11, 2024 16:47
@FredKSchott FredKSchott force-pushed the add-success-fail-handling branch from 6260e47 to 571c742 Compare March 11, 2024 16:49
bholmesdev
bholmesdev approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely need an abstraction for handling Studio errors and some refinement on status codes. Won't block for this PR though. That's the entry-point of polish week!

packages/db/src/core/cli/commands/push/index.ts Show resolved Hide resolved
@FredKSchott
Copy link
Member Author

100% agreed

@FredKSchott FredKSchott merged commit 8a23ee5 into main Mar 11, 2024
13 checks passed
@FredKSchott FredKSchott deleted the add-success-fail-handling branch March 11, 2024 19:32
@astrobot-houston astrobot-houston mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico left review comments

@bholmesdev bholmesdev bholmesdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FredKSchott @ematipico @bholmesdev