Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove drop table check for added table #10396

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

Remove call to "drop table if exists" when adding a table. This allowed tables to be dropped unexpectedly on a bad migration merge. This was an unexpected bug, and should raise a SQL error instead of dropping user data.

Testing

Docs

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 58caa48

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp matthewp merged commit 41ca94e into main Mar 12, 2024
13 checks passed
@matthewp matthewp deleted the fix/dont-drop-added-collection branch March 12, 2024 11:30
@astrobot-houston astrobot-houston mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants