deprecation(vercel): vercel-edge-middleware.js file #10476
Merged
+34
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 94f9d79 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
lilnasy
force-pushed
the
vercel-middleware-simplification
branch
from
c1ad0d7 to
94f9d79
Compare
bholmesdev
approved these changes
Mar 18, 2024
ematipico
requested changes
Mar 18, 2024
There was a problem hiding this comment.
A couple of things. The first one (the important one) is that we must expose the types to the users to augment the Astro.locals types.
The second one (less important), is that Netlify and Cloudflare adapters have using their named object e.g. Astro.locals.netlify. It would be nice if we could align it, but it's nice to have.
|
@ematipico addressed |
ematipico
approved these changes
Mar 19, 2024
|
@ematipico Added docs for typing here: withastro/docs#7485 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
vercel-edge-middleware.jsfile allowed users to access the vercel edge runtime'sRequestContextobject, and create the middlewarelocalsfrom its fields. However, this object includes only one field - thewaitUntil()function - which is now available directly asctx.locals.waitUntil().console.log(context)Testing
Docs