Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sitemap): fix missing base path in sitemap-index.xml #10557

Merged
merged 3 commits into from
Mar 26, 2024
Merged

fix(sitemap): fix missing base path in sitemap-index.xml #10557

merged 3 commits into from
Mar 26, 2024

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Mar 26, 2024

Changes

Testing

  • Test cases updated
  • pnpm --filter @astrojs/sitemap run test

Docs

  • Probably not needed to update because:
    • The base path is not specifically mentioned in the docs
    • The examples do not use the base config either

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 20b3e10

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 26, 2024
@matthewp matthewp merged commit 5f7e9c4 into withastro:main Mar 26, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 26, 2024
@mingjunlu mingjunlu deleted the fix/sitemap-index-xml-incorrect-base branch March 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sitemap integration generates incorrect location path
3 participants