db: Rework index config with generated index names

[bholmesdev]

Changes

This introduces generated index names when passing an array to indexes. The object configuration syntax is now deprecated. See changelog

• Update dbConfig with a transformation step to generate index names by table and column names
• Introduce a ResolvedDbConfig type for migration queries
• Misc: add a mapObject utility to remap object values with type safety

Testing

Add tests for new array format, and move old tests to "legacy"

Docs

withastro/docs#7639

[changeset-bot]

🦋 Changeset detected

Latest commit: 064d001

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bholmesdev]

Kept to a patch since the old config object is deprecated, but still works! Made a ticket to remove in the next minor.

[matthewp]

Just to check, this is non-breaking, the old syntax is still supported for now, right?

[matthewp]

What will happen to people's existing indices? Will they be dropped and recreated?

[bholmesdev]

Old syntax is supported! And it shouldn't drop and recreate even when refactoring to the new syntax (unless you switch to using generated names of course). We handle everything with a Zod transform that matches the original object format. I'll add a unit test to confirm

[matthewp]

I guess what i'm asking is, currently the user can name them whatever they want. For example foobar_index. But now with the automated index names, is it not going to try to add the new index and not know about the previous index?

I guess you're saying that when you do push, it will see the old index and the new index and drop the old one (assuming it doesn't match) and create a new one?

[bholmesdev]

Update: confirmed there are no migrations when upgrading to the new syntax

[bholmesdev]

@matthewp Yep, it will drop and recreate the indexes if you don't pass a name option. If you pass a name to the new indexes that matches the old name, it'll run without any migrations 👍