Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary recmaInjectImportMetaEnv plugin for MDX #10673

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 4, 2024

Changes

This plugin is no longer needed as Vite 5 can replace import.meta.env properly avoiding strings. This saves about 1.2s for the docs build.

image

Testing

The plugin was added in #4858 which has tests that should still pass in this PR.

Docs

n/a. internal refactor.

Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: 7cb47d9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Apr 4, 2024
@bluwy bluwy merged commit db7f9c8 into main Apr 4, 2024
13 checks passed
@bluwy bluwy deleted the mdx-no-recma branch April 4, 2024 07:07
@astrobot-houston astrobot-houston mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants