-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MDX cannot find relative image path without leading ./
#10705
Conversation
🦋 Changeset detectedLatest commit: 40faa5a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful
I think we called this a minor when we did it for .md #9755 and I guess https://semver.org/ specifies that when you add functionality it becomes a minor, but this could be seen as simply fixing a bug where ./ was incorrectly required as the syntax without ./ should have always been valid
What do you think @rishi-raj-jain? |
Appreciate the thorough review. Does make sense.
I think I still need to learn where to mark it as a minor / patch as sometimes I just end up confusing between them. The PR can be seen as fixing a bug because it's "expected" to be able to use the paths without slashes, or be seen as an added functionality from the creators perspective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR can be seen as fixing a bug because it's "expected"
A good way to understand that is if the docs mention this feature. If not, than it's not a bug. In fact, why don't we update the docs to show the new feature?
@rishi-raj-jain I ask you the following tasks, if you don't mind:
- update the test section of the template, and tell us how you tested the feature. Ideally, we want to add a new test
- update the docs section of the template, and link the docs PR where we add a new example
added tests. |
|
Changes
fixes #10641
Ensures prefix if not present in the referenced image.
Testing
Docs
withastro/docs#7856