Fix @types/cookie dependency

[fshafiee]

Changes

Promotes @types/cookie to standard package dependencies to fix cookie types.

When authoring packages with Typescript support in mind, DefinitelyTyped (a.k.a @types/...) packages should appear in the same dependency category as their counterpart.

To expand further, imagine there’s a package that ships natively with its types:

{
  "dependencies": {
    "typed-package": "...",
  }
}

We get runtime files and type together.
Now, had the authors decided to distribute typedefs separately, the analogous syntax would have been:

{
  "dependencies": {
    "@type/untyped-package": "...",
    "untyped-package": "..."
  }
}

Not:

{
  "dependencies": {
    "@type/untyped-package": "..."
  },
  "devDependencies": {
    "untyped-package": "..."
  }
}

Context: #10671

Related SO conversation: https://stackoverflow.com/questions/45176661/how-do-i-decide-whether-types-goes-into-dependencies-or-devdependencies

Testing

Clone https://github.com/jlarmstrongiv/astro-cookie-types (prepared by @jlarmstrongiv) and run npm install @types/cookie. Type errors will resolve and IDE annotations will appear instead.

Docs

Not needed.

[changeset-bot]

🦋 Changeset detected

Latest commit: 12fa718

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[lilnasy]

Looks great, just needs a changeset!

[fshafiee]

@lilnasy Just added the changeset.