Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables view transition e2e tests with Firefox #11093

Merged
merged 1 commit into from
May 21, 2024
Merged

Enables view transition e2e tests with Firefox #11093

merged 1 commit into from
May 21, 2024

Conversation

martrapp
Copy link
Member

@martrapp martrapp commented May 17, 2024

Changes

Adds e2e/view-transitions.test.js to playwright.firefox.config.js, see #11036.

=> e2e tests for view transitions will now not only run on Chrome, but also run on Firefox.

Our approach for counting full page loads during navigation was off by one as Firefox always generated an additional load for about:blank for each test case.

Few tests do not work the same or at all for simulated view transitions

  • "No page rendering during swap()": Other than the native implementation, the simulation can not stop the renderer.
  • "transition:name should be escaped correctly": setting view-transition-name w/o native support is a CSS error.
  • "animation get canceled when view transition is interrupted": as entry animations run before exit animations in the simulation, only the entry animations get canceled.

Testing

e2e tests for view transitions now also run on Firefox.

Docs

/cc @withastro/maintainers-docs, I assume it is OK not to have changeset for this PR?

Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: 8972fe4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 17, 2024
@martrapp martrapp merged commit a514bbe into main May 21, 2024
13 checks passed
@martrapp martrapp deleted the firefox-e2e branch May 21, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants