Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backwards compat with Astro <= 4.9 in Node and Vercel adapters #11261

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Fix backwards compat with Astro <= 4.9 in Node and Vercel adapters #11261

merged 1 commit into from
Jun 14, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • Even though the code uses a dynamic import with a catch, this still breaks in the build because Rollup tries to build that import.
  • Moving the import specifier to a variable lets us hide from Rollup, while still dynamically importing this module at runtime.

Testing

  • Can't create unit tests for this since it requires Astro <= 4.9. Tested manually.

Docs

N/A, bug fix

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 5b01112

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 14, 2024
florian-lefebvre
florian-lefebvre approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll also need this for netlify and cloudflare

@matthewp matthewp merged commit f5f8ed2 into main Jun 14, 2024
13 checks passed
@matthewp matthewp deleted the env-compat branch June 14, 2024 20:29
@astrobot-houston astrobot-houston mentioned this pull request Jun 14, 2024
Merged
@alexanderniebuhr alexanderniebuhr mentioned this pull request Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@Fryuni Fryuni Fryuni approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewp @Fryuni @florian-lefebvre