-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use typescript-eslint@v8's projectService for typed linting #11315
chore: use typescript-eslint@v8's projectService for typed linting #11315
Conversation
|
@JoshuaKGoldberg are you able to rebase this? Hoping to start using typescript-eslint v8! |
I'm looking into the failures now. It's some fun internal debugging. 👨💻 |
// /Users/josh/repos/astro/packages/upgrade/upgrade.mjs | ||
// 0:0 error Parsing error: /Users/josh/repos/astro/packages/upgrade/upgrade.mjs was not found by the project service. | ||
// Consider either including it in the tsconfig.json or including it in allowDefaultProject | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I figured it out. https://github.com/JoshuaKGoldberg/repros/tree/tseslint-project-service-non-included-nearest-tsconfig is a simplified reproduction.
Basically:
packages/upgrade/tsconfig.json
includes["src"]
packages/upgrade/upgrade.mjs
is not in that includes- The project service therefore isn't picking up the file
This would be a good case to stick with parserOptions.project
, to give more fine-grained control over what projects include each file. I filed typescript-eslint/typescript-eslint#9753 to document this better.
Closing in favor of #11649. 👍 |
Changes
Similar to #7425, this:
projectService: true
for typed linting, instead ofproject: true
&tsconfig.eslint.json
It's giving out-of-memory crashes on my machine, so sending as a draft...