Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more unused code #11598

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Remove more unused code #11598

merged 2 commits into from
Aug 2, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 2, 2024

Changes

I felt great from yesterday's PR and decided to remove more unused code using https://knip.dev, and might've went overboard 😅 This PR:

  • Removes unused code and types
  • Removes unused exports (only for some that helps readability
  • Removes unused dependencies
  • Simplifies eslint config

Testing

Existing tests should pass

Docs

n/a. internal change.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c1958de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 2, 2024
ematipico
ematipico approved these changes Aug 2, 2024
View reviewed changes
packages/astro/package.json Outdated Show resolved Hide resolved
@bluwy bluwy merged commit 69d54b4 into main Aug 2, 2024
14 checks passed
@bluwy bluwy deleted the remove-more-unused-stuff branch August 2, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @ematipico