Prevent Partytown integration from inserting a 'null' string into the body #11829
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 42f633e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
oosawy
changed the title
bluwy
approved these changes
Aug 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When using astro/partytown with astro:transitions, if partytown failed to load, it inserts "null" string into the page during transition. This mainly occurs in non-Secure Context where Service Worker that partytown needs can't be install. For example, if you're accessing it via an IP address on a LAN during development, it isn't served over HTTPS or on localhost so it's not Secure Context.
This PR prevent that by append a element only if found.
― The script going to append "null"
― The added "null" string node
Testing
Building @astrojs/partytown, linking it to my project, and confirming no "null" were inserted during page transitions.
Docs
This should be a minor bug fix affecting only special cases, so no docs will be required.