Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user-facing type for i18n.routing.fallbackType #11900

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 2, 2024

Changes

The new i18n.routing.fallbackType option added in Astro 4.15 is optional, but typed as required. This PR fixes that.

Testing

Tiny change, so no tests required.

Docs

n/a — bug fix only

Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: d9de6fb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Sep 2, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this was the intention, as this was not supposed to be a breaking change for anyone who didn't have this set! Thank you, Chris!

@delucis delucis merged commit 80b4a18 into main Sep 2, 2024
14 checks passed
@delucis delucis deleted the chris/fix-fallbackType-type branch September 2, 2024 11:01
@astrobot-houston astrobot-houston mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants