Fix VT video test fail in firefox #12188
Conversation
|
github-actions
bot
added
the
pkg: astro
| test('<video> can persist using transition:persist', async ({ page, astro }) => { | ||
| test('<video> can persist using transition:persist', async ({ page, astro, browserName }) => { | ||
| // NOTE: works locally but fails on CI | ||
| test.skip(browserName === 'firefox', 'Firefox has issues playing the video. Errors on play()'); |
There was a problem hiding this comment.
we don't run it in firefox in CI do we?
There was a problem hiding this comment.
We do with test:e2e:firefox
|
My PR didn't need to disable firefox, so hopefully it was the video that was the issue. |
|
I want to disable firefox because the test is not testing on firefox correctly due to a weird firefox behaviour. It's not due to the archive.org video bug. |
Changes
Fix the fail happening in main now due to archive.org being down. This commits a video (493KB) to git so we can fetch the video locally.
I also fixed the tests where the video didn't really run at all.
UPDATE: I simply skipped in on firefox for now as for some reason it keeps on failing on CI, even if it works for me locally.
Testing
pnpm test:e2e:firefox view-transitionsDocs
n/a