Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some examples #12196

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Remove some examples #12196

merged 2 commits into from
Oct 11, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 11, 2024

Changes

Removes:

  • middleware
  • non-html-pages
  • server-islands
  • view-transitions
  • with-markdown-plugins (docs already has examples)
  • with-markdown-shiki (already the default)

Most of these examples are created while developing the feature. Now they're common enough that I think users are better off referencing the docs for up-to-date information instead.

I did not remove:

  • container-with-vitest (since it's still experimental, it's still useful to have its own example for testing)
  • ssr (has quite an amount of useful code. i think it can be cleaned up in the future to not rely of svelte as its framework specific)
  • framework-lit (we still support it in astro 4, so not removing for now)

With this PR that removes 6 examples, it brings down our templates count from 31 to 25. Let me know if you disagree with removing an example, I'm happy to revert/discuss it.

Testing

n/a

Docs

n/a

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 849208e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Oct 11, 2024
@bluwy bluwy merged commit fd367b5 into main Oct 11, 2024
14 checks passed
@bluwy bluwy deleted the remove-examples branch October 11, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants