Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setOnSetGetEnv parameter name #12220

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix setOnSetGetEnv parameter name #12220

merged 2 commits into from
Oct 14, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 14, 2024

Changes

fix #12210

The parameter name should be prefixed with an underscore as it's used here:

onSetGetEnv += `${key} = reset ? undefined : _internalGetSecret(${JSON.stringify(key)});\n`;
}
server = server.replace('// @@ON_SET_GET_ENV@@', onSetGetEnv);

Testing

Existing tests should pass. Probably should add a test for this, but I'm not sure how at the moment.

Docs

n/a

Co-authored-by: Fugi <Fugiman47@gmail.com>
Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 589ae67

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 14, 2024
@bluwy bluwy merged commit b049359 into main Oct 14, 2024
4 checks passed
@bluwy bluwy deleted the fix-get-set-env-var branch October 14, 2024 07:12
@astrobot-houston astrobot-houston mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsequent environment variable reads fail when using astro:env API
2 participants