fix(@astro/mdx): add components property to RenderResult type definition #12245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e5f5d9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
bmenant
force-pushed
the
fix/mdx-components-render-type
branch
from
57881ac to
b6d2294
Compare
bmenant
force-pushed
the
fix/mdx-components-render-type
branch
from
b6d2294 to
5e5f5d9
Compare
github-actions
bot
added
pkg: astro
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Render['.mdx']type definition lacks acomponentsproperty #12244componentsproperty to Astro’sMDXInstancetype definition.componentsproperty to RenderResult in the template type definition of@astro/mdxintegration.Testing
Only a type definition change, not sure how to test this properly over here?
Did run
pnpm --filter @astro/mdx run test: all existing tests passed.pnpm buildpasses.Tested locally on the minimal reproduction repo.
Docs
Only a type definition change.