Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server island route to the front of the route list #12263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Oct 19, 2024

Changes

The route was being added as the last route in the list, making it the lowest priority. The solution would be to either add it before the routes are sorted by priority or make it higher than other routes.

IMO internal routes should come first since they are required for native Astro features to work, so adding it to the front of the list is enough. If we think they should follow the normal route priority then the fix is different (insert the route based on the priority rules).

Testing

Added a conflicting route on the e2e test fixture to reproduce the problem.

Docs

Maybe document the prefixes reserved for Astro functionality (_server-islands/, _actions and _astro)

Copy link

changeset-bot bot commented Oct 19, 2024

⚠️ No Changeset found

Latest commit: f6f9bc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch all page ([...slug].astro) catch all Server island requests
1 participant