feat(actions): getActionPath() #12721
Conversation
🦋 Changeset detectedLatest commit: a71b0e5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
CodSpeed Performance ReportMerging #12721 will not alter performanceComparing Summary
|
|
The name of the actual function will probably change after docs feedback |
| await fetch(getActionPath(actions.like), { | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: 'Bearer YOUR_TOKEN' | ||
| }, | ||
| body: JSON.stringify({ id: 'YOUR_ID' }), | ||
| keepalive: true | ||
| }) |
There was a problem hiding this comment.
Thanks for adding this! I think it's definitely worth noting that actions do not return plain JSON. They return values that are parsable by the devalue library. I suggest using the deserializeActionResult() utility from astro:actions for this.
There was a problem hiding this comment.
Ah good call thank you!
There was a problem hiding this comment.
Thanks @bholmesdev -- is showing using deserializeActionResult() in this context concise? I realized we only have a short API reference sentence for this (no example usage), and no example using this anywhere in docs. (So, I'm not sure if this can be shown quickly or not.)
This would be a great addition to the actual docs (where I don't really care if it's concise or not), and if it's easy to do here, would also be a great place to put it!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
There was a problem hiding this comment.
One comment left for @florian-lefebvre as an optional type of improvement, but non-blocking and approving for docs!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Changes
getActionPath()helperTesting
Adds a test case
Docs
Changeset and withastro/docs#10353