fix(toolbar): assign label to icons

[ematipico]

Changes

There were some accessibility issues related to the labels of icons and buttons in our toolbar. This PR should fix it.

Testing

CI should pass

Docs

N/A

[codspeed-hq]

CodSpeed Performance Report

Merging #12734 will not alter performance

_{Comparing fix/toolbar-bar-label-icons (31314a7) with main (f3d8385)}

Summary

✅ 4 untouched benchmarks

[delucis]

We shouldn’t use <title> here as it introduces a duplicate tooltip for those using a mouse to hover:

I also did some screenreader testing and it appears these changes are not required — the buttons already include accessible labels in the accessibility tree when testing with the version on main:

Instead, we should hide the SVGs using aria-hidden="true".

[changeset-bot]

⚠️ No Changeset found

Latest commit: 31314a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[delucis]

Thanks for the changes @ematipico! They look good. Just one question.

[delucis]

Perfect. OK, should be good to go I think! Thanks for bearing with me on this one 🙌