Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug logging from output #12756

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Remove debug logging from output #12756

merged 1 commit into from
Dec 16, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • Logging added while working on bug but not removed!
  • Want to get a patch out so users don't see this.

Testing

  • N/A

Docs

  • N/A

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: ed24650

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 16, 2024
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #12756 will degrade performances by 35.26%

Comparing remove-log (ed24650) with main (75de4a8)

Summary

❌ 1 regressions
✅ 3 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main remove-log Change
Rendering: streaming [false], .md file 14.7 ms 22.7 ms -35.26%

@matthewp
Copy link
Contributor Author

Apparently you can't restart a CodSpeed. Nevertheless, since we know that this is a false-positive going to ignore and get this fix in.

@matthewp matthewp merged commit 95795f8 into main Dec 16, 2024
15 of 16 checks passed
@matthewp matthewp deleted the remove-log branch December 16, 2024 21:25
@astrobot-houston astrobot-houston mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant