fix: defer validation of reference entries

[ascorbic]

Changes

Currently we attempt to validate references in schemas by checking the referenced entry exists. This causes a problem if a new referenced entry is added at the same time as the reference is added, because there can be a race condition where the referenced entry has not yet been added to the store when the reference is validated.

This PR removes that check. This is OK (and we already skip validation if the collection doesn't exist yet) because we also validate at runtime.

Fixes #12680
Fixes #12885

Testing

Adds a test

Docs

[changeset-bot]

🦋 Changeset detected

Latest commit: 9cd2105

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #12990 will not alter performance

_{Comparing defer-reference-validation (9cd2105) with main (1a026af)}

Summary

✅ 6 untouched benchmarks

[florian-lefebvre]

Are references still checked during build?

[ascorbic]

@florian-lefebvre they're checked during rendering, which is what we already do for uncached builds now anyway

[florian-lefebvre]

So they wouldn't be caught in on-demand routes. I think it would make sense to always check references after all loaders are loaded (to avoid race conditions) during uncached builds, let me know what you think

[ascorbic]

So they wouldn't be caught in on-demand routes. I think it would make sense to always check references after all loaders are loaded (to avoid race conditions) during uncached builds, let me know what you think

The problem is that these validations are happening in the loaders, when users call parseData.

[ascorbic]

I am thinking I may need to move to a post-sync validation step, but it's hard to think how to do it without it being a breaking change