Prevent <Markdown> blocks from locking up vscode extension #269
Conversation
|
| "begin": "(?:^\\s+)?(<)(Markdown)\\b(?=[^>]*)", | ||
| "name": "text.html.astro.markdown", | ||
| "begin": "(<)(Markdown)(>)", |
There was a problem hiding this comment.
I appreciate how straightforward this is, but does this preclude us from exposing props in the future?
There was a problem hiding this comment.
I can try and add that.
There was a problem hiding this comment.
Not a huge deal, we can cross that bridge when we get there. That was the intent of the #tag-stuff include, though.
There was a problem hiding this comment.
Yeah, the reason why I simplified it was because the old way was causing the end tag to not be highlighted when there were no children and I could figure out what caused it. Might just leave it this simple way for now and expand later.
We shouldn't have to define that a Markdown behaves like a normal element though, we should get that for free, so there might be an issue with ordering going on (or we might need to switch to lookbehinds/lookaheads so that it only cares about the inside of Markdown tags)
Changes
Simplifies the grammar a little and gets rid of a block that was causing infinite recursion.
Testing
Docs