Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for allowing space in folder name #2797

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Fix for allowing space in folder name #2797

merged 3 commits into from
Mar 15, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Tested manually with the Stackblitz project.
  • Tried adding a Unit test but because of the monorepo the path to the internal astro file does not contain a space. So adding a fixture with a space in the folder name doesn't help.
  • Would need better integration test infrastructure to do this.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2022

🦋 Changeset detected

Latest commit: 010fd57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 75 packages
Name Type
astro Patch
@astrojs/test-0-css Patch
@astrojs/test-astro-assets Patch
@astrojs/test-astro-attrs Patch
@astrojs/test-astro-basic Patch
@astrojs/test-astro-children Patch
@astrojs/test-astro-class-list Patch
@astrojs/test-astro-client-only Patch
@astrojs/test-astro-component-code Patch
@astrojs/test-astro-components Patch
@astrojs/test-astro-css-bundling-import Patch
@astrojs/test-astro-css-bundling-nested-layouts Patch
@astrojs/test-astro-css-bundling Patch
@astrojs/test-astro-directives Patch
@astrojs/test-astro-doctype Patch
@astrojs/test-astro-dynamic Patch
@astrojs/test-astro-envs Patch
@astrojs/test-astro-expr Patch
@astrojs/test-astro-external-files Patch
@astrojs/test-astro-fallback Patch
@astrojs/test-astro-get-static-paths Patch
@astrojs/test-astro-global Patch
@astrojs/test-astro-jsx Patch
@astrojs/test-astro-markdown-drafts Patch
@astrojs/test-astro-markdown-plugins Patch
@astrojs/test-astro-markdown-skiki-langs Patch
@astrojs/test-astro-markdown-skiki-normal Patch
@astrojs/test-astro-markdown-skiki-themes-custom Patch
@astrojs/test-astro-markdown-skiki-themes-integrated Patch
@astrojs/test-astro-markdown-skiki-wrap-false Patch
@astrojs/test-astro-markdown-skiki-wrap-null Patch
@astrojs/test-astro-markdown-skiki-wrap-true Patch
@astrojs/test-astro-markdown Patch
@astrojs/test-astro-page-directory-url Patch
@astrojs/test-astro-pages Patch
@astrojs/test-astro-pagination Patch
@astrojs/test-astro-partial-html Patch
@astrojs/test-astro-public Patch
@astrojs/test-astro-scripts Patch
@astrojs/test-astro-sitemap-rss Patch
@astrojs/test-astro-slots Patch
@astrojs/test-config-host Patch
@astrojs/test-config-hostname Patch
@astrojs/test-config-path Patch
@astrojs/test-config-port Patch
@astrojs/test-custom-elements Patch
@astrojs/test-debug-component Patch
@astrojs/test-errors Patch
@astrojs/test-fetch Patch
@astrojs/legacy-build Patch
@astrojs/test-lit-element Patch
@astrojs/test-markdown Patch
@astrojs/test-postcss Patch
@astrojs/test-preact-component Patch
@astrojs/test-react-component Patch
@astrojs/test-remote-css Patch
@astrojs/test-route-manifest Patch
@astrojs/test-sass Patch
@astrojs/test-slots-preact Patch
@astrojs/test-slots-react Patch
@astrojs/test-slots-solid Patch
@astrojs/test-slots-svelte Patch
@astrojs/test-slots-vue Patch
@astrojs/test-solid-component Patch
@astrojs/test-static-build Patch
@astrojs/test-static-build-code-component Patch
@astrojs/test-static-build-frameworks Patch
@astrojs/test-static-build-page-url-format Patch
@astrojs/test-svelte-component Patch
@astrojs/test-vue-component Patch
@astrojs/test-with-endpoint-routes Patch
@astrojs/test-with-subpath-no-trailing-slash Patch
@astrojs/test-with-subpath-trailing-slash Patch
@astrojs/test-without-site-config Patch
@astrojs/test-without-subpath Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 15, 2022
@matthewp matthewp force-pushed the space-in-filename branch from 4e481a1 to a9ad289 Compare March 15, 2022 12:45
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had no viteIDea it was so simple!

@matthewp matthewp merged commit 58d8686 into main Mar 15, 2022
@matthewp matthewp deleted the space-in-filename branch March 15, 2022 15:26
@github-actions github-actions bot mentioned this pull request Mar 15, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fix for allowing space in folder name

* Adds a changeset

* Prepend a forward slash, for windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Error Failed to load module for SSR
2 participants