Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build to a single file #2873

Merged
merged 14 commits into from
Mar 24, 2022
Merged

Build to a single file #2873

merged 14 commits into from
Mar 24, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Changes the build so that there is 1 single bundle for the entire app.
  • This is needed for some SSR hosts.
  • Also might speed up static builds.
  • Fixes endpoint routes in SSR.
  • The change is to remove the use of facadeId maps in the internals module. Instead we put metadata about a route in the existing BuildPageData object.
  • vite-plugin-pages is the entry module for the build. It imports all routes and prepares itself for static rendering / ssr.
  • vite-plugin-ssr is the entry for SSR. It imports the vite-plugin-pages module and implements the adapter API.

Testing

  • Test added for SSR endpoint routes.
  • Otherwise this is mostly just a refactor.

Docs

Not yet, separate issue.

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2022

🦋 Changeset detected

Latest commit: 84b3977

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
@astrojs/node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Mar 24, 2022
@matthewp matthewp marked this pull request as ready for review March 24, 2022 12:39
@matthewp matthewp force-pushed the single-file-build-3 branch from a2e454b to 030c302 Compare March 24, 2022 15:14
@matthewp matthewp force-pushed the single-file-build-3 branch from e587f9d to d63a4cb Compare March 24, 2022 17:24
@natemoo-re
Copy link
Member

Can't seem to leave a review right now, but looks good!

Saw one stray console.log at

@matthewp matthewp merged commit e4025d1 into main Mar 24, 2022
@matthewp matthewp deleted the single-file-build-3 branch March 24, 2022 21:08
This was referenced Mar 24, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Build to a single file

* Updates based on initial code review

* Adds a changeset

* Use the default export for cjs module

* Await generatePages

* Prevent timing from causing module to not import

* Fix shared CSS

* Properly handle windows ids

* Dont shadow

* Fix ts errors

* Remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants