Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an adapter to export default #3022

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Allow an adapter to export default #3022

merged 2 commits into from
Apr 7, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Apr 7, 2022

Changes

  • Adapters were not able to export default and some need to.
  • A workaround was added for Vercel where _default became the default export.
  • This was not obvious and not documented, so better just to allow a default export. This fixes that.

Testing

  • Test adapter exports a default which exposed the bug.

Docs

N/A, already covered by the adapter docs (just fixes a bug).

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2022

🦋 Changeset detected

Latest commit: 953f97e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
@astrojs/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 7, 2022
@matthewp matthewp requested a review from JuanM04 April 7, 2022 16:37
@matthewp matthewp self-assigned this Apr 7, 2022
Copy link
Contributor

@JuanM04 JuanM04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewp matthewp merged commit 8c04ff1 into main Apr 7, 2022
@github-actions github-actions bot mentioned this pull request Apr 7, 2022
@JuanM04 JuanM04 deleted the ssr-export-default branch April 7, 2022 17:25
This was referenced Apr 11, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Allow an adapter to export default

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants