Allow setting multiple cookies in Netlify adapter #3092
Conversation
🦋 Changeset detectedLatest commit: 15cd9fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
| body: responseBody, | ||
| }; | ||
|
|
||
| // Special-case set-cookie which has to be set an different way :/ |
There was a problem hiding this comment.
so strange. mind expanding a bit on why exactly this is needed, for future readers?
There was a problem hiding this comment.
Yeah sure, the tldr here is that the Fetch API concatenates headers and comma-separates them when you try to get them with headers.get('foo'). Set-Cookie is the only header that doesn't work comma-separated and must be set with multiple Set-Cookie headers. Fetch does not have an API for that, because there's no need for it in the browser.
Luckily node-fetch has a special API for this use-case and Netlify will always use that polyfill so its safe to use. Other adapters will have to do it different ways, since there is no standard.
For reference (with various host providers weighing in): whatwg/fetch#973
There was a problem hiding this comment.
I'll add a comment with a link to that issue.
|
perfect, thanks! LGTM to merge |
Changes
Testing
Test added
Docs
N/A, bug fix