Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to verify Lit works in SSR #3158

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Add test to verify Lit works in SSR #3158

merged 1 commit into from
Apr 20, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Added a test to verify that Lit works in SSR, and it does.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2022

⚠️ No Changeset found

Latest commit: b0bea49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Apr 20, 2022
@matthewp matthewp merged commit 12f6b60 into main Apr 20, 2022
@matthewp matthewp deleted the lit-ssr branch April 20, 2022 18:16
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Window is not defined after using lit integration when deployed on netlify
1 participant