Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 'lit' always be bundled in SSR #3164

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Make 'lit' always be bundled in SSR #3164

merged 2 commits into from
Apr 21, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Test updated.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 9be8339

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
@astrojs/lit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) test labels Apr 21, 2022
tony-sull
tony-sull approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

bholmesdev
bholmesdev approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is, literally, the best PR I've seen

@matthewp matthewp merged commit e85b16e into main Apr 21, 2022
@matthewp matthewp deleted the lit-ssr-2 branch April 21, 2022 15:12
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@matthewp
Make 'lit' always be bundled in SSR (withastro#3164)
e4bc30c 
* Make 'lit' always be bundled in SSR

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bholmesdev bholmesdev bholmesdev approved these changes

@tony-sull tony-sull tony-sull approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Window is not defined after using lit integration when deployed on netlify
3 participants
@matthewp @tony-sull @bholmesdev