Feat: support astro add without npm installing
#3183
Merged
+49
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 929959e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
|
Ah ha! I remember what happened here. I did some refactoring when I added |
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* deps: update to latest proload * feat: avoid parsing config on resolveConfigUrl * chore: changeset * fix: bump proload * fix: bump proload * fix: bump proload * fix: bump proload * fix: bump proload Co-authored-by: Nate Moore <nate@skypack.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: we want to add
astro addto thecreate-astroworkflow. However, this command fails when the user hasn't installed dependencies. This PR removes config parsing to prevent such errors.Changes
resolvewithinresolveConfigUrl-> prevents parsing the config file when resolving the file pathresolvefunctionTesting
N/A
Docs
N/A