Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename dts to ts file #3332

Merged
merged 3 commits into from
May 10, 2022
Merged

rename dts to ts file #3332

merged 3 commits into from
May 10, 2022

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented May 10, 2022

Changes

Testing

  • Should this be tested? I guess we could add a test that no .d.ts bugs
  • Update: looks like eslint really isn't designed for file name checks, and we don't have package/astro specific eslint rules. I think we can skip a test given how infrequent this will be.

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2022

🦋 Changeset detected

Latest commit: 415a86e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 10, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +2

@FredKSchott FredKSchott merged commit d04928e into main May 10, 2022
@FredKSchott FredKSchott deleted the rename-dts-to-ts branch May 10, 2022 20:54
@github-actions github-actions bot mentioned this pull request May 10, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* rename dts to ts file

* Create new-carrots-cough.md

* add back missing types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Type error: Cannot find module ../core/build/types
2 participants