HMR hoisted scripts #3336
Merged
HMR hoisted scripts #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa713d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
This was referenced May 10, 2022
Closed
FredKSchott
reviewed
May 10, 2022
| // HMR hoisted script only exists to make them appear in the module graph. | ||
| if(opts?.ssr) { | ||
| return { | ||
| code: '' |
There was a problem hiding this comment.
nit: can this be a comment like /* client hoisted script, empty in SSR */? Bonus if it can also include the file path or some other useful debug info.
FredKSchott
approved these changes
May 10, 2022
Merged
1 task
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* HMR hoisted scripts * Add to the dep graph * Remove example change * Adds changeset * Fix markdown test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Manually tested via an example.
Docs
N/A, bug fix.