Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inject script for ssr mode #3339

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

thepassle
Copy link
Contributor

Changes

fixes #3298

My TS-fu failed me on this one, so please let me know if the TS/checks can be improved

Testing

locally

Docs

no docs update needed

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2022

🦋 Changeset detected

Latest commit: 3f16022

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 11, 2022
@matthewp
Copy link
Contributor

Thanks!

@matthewp matthewp merged commit 3dc68e1 into withastro:main May 11, 2022
@github-actions github-actions bot mentioned this pull request May 11, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* fix: inject script for ssr mode

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: injectScript only works during dev or SSG mode, not SSR (build only)
2 participants