Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error recovery test and more #3388

Merged
merged 3 commits into from
May 17, 2022
Merged

Error recovery test and more #3388

merged 3 commits into from
May 17, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Fixes fixed APIRoute type #3365
  • Passing a list of deps to import.meta.hot.accept results in modules in the module registry being overridden, so when we try to crawl deps to find CSS we don't find any.
    • This is likely a Vite bug.
  • The fix is to not pass deps to import.meta.hot.accept, which turns out to not be needed.

Testing

  • Test added for the error recovery bug, which was the original reason this code was changed and cause the regression. It turns out this part of that change isn't needed.
  • playwright test added to ensure styles for nested components exist on initial page load.

Docs

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

🦋 Changeset detected

Latest commit: 0ea0eae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 17, 2022
@matthewp
Copy link
Contributor Author

Fix is in #3388, just waiting on a review.

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewp matthewp merged commit 4d00473 into main May 17, 2022
@matthewp matthewp deleted the error-recovery-test-and-more branch May 17, 2022 15:43
@github-actions github-actions bot mentioned this pull request May 17, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Add test to verify errors are recovered from

* Fix nested style components not be added in dev on initial load

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants