Updates hydration scripts to use absolute paths #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b72f3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
@tony-sull think there's just a few tests needing to be updated. |
|
@matthewp gotta love good test coverage! There was a legit Windows bug in there that the test caught, the PR wasn't forcing posix paths in the build's |
matthewp
approved these changes
May 23, 2022
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* WIP: proof of concept fix to use absolute paths * correct fix to handle absolute paths and config.base * adding tests for hydration scripts with config.base * chore: add changeset * fix: ensure posix paths are used for Windows compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2561
Changes
This updates hydration scripts to use absolute paths when importing scripts. This is necessary to make sure any client-hydrated scripts on a custom 404 page are loaded properly
Testing
Updated existing tests and added two new ones to confirm this behavior when
config.baseis used to deploy to subpathsDocs
None, bug fix only