Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dynamic imports when using Netlify Edge Functions #3535

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jun 6, 2022

Changes

Testing

Test added

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2022

🦋 Changeset detected

Latest commit: c67cd81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 6, 2022
@matthewp matthewp force-pushed the fix-netlify-edge2 branch from d9f6ca3 to c67cd81 Compare June 6, 2022 17:44
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Think the branch just needs to be updated from main to remove the change to the Deno integration's package.json

packages/integrations/deno/package.json Show resolved Hide resolved
@matthewp matthewp requested a review from tony-sull June 6, 2022 19:41
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matthewp matthewp merged commit f3ab822 into main Jun 7, 2022
@matthewp matthewp deleted the fix-netlify-edge2 branch June 7, 2022 15:41
@github-actions github-actions bot mentioned this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants