Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @astrojs/cloudflare 404 handling #3695

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

nrgnrg
Copy link
Contributor

@nrgnrg nrgnrg commented Jun 23, 2022

Changes

perviously requests that we're 404'ing would fall through and not render a custom 404 page if one existed.

This change rectifies that.

  • if a request does not match a route check if 404 matches a route
  • if 404 matches render that
  • else default as before

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2022

🦋 Changeset detected

Latest commit: 7ed9ebd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 23, 2022
@nrgnrg nrgnrg force-pushed the cloudflare/404-handling branch 2 times, most recently from 4d8a5ea to 0fd18ec Compare June 23, 2022 19:41
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think a patch makes sense!

.changeset/five-zoos-look.md Outdated Show resolved Hide resolved
@natemoo-re natemoo-re changed the title fix: @astrojs/clooudflare 404 handling fix: @astrojs/cloudflare 404 handling Jun 24, 2022
@natemoo-re natemoo-re merged commit 0d667d0 into withastro:main Jun 24, 2022
@github-actions github-actions bot mentioned this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants