feat: add support to @astrojs/cloudflare directory deploy mode
#3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a1aa4a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
nrgnrg
force-pushed
the
feat/directory-mode
branch
from
6773126 to
fbc6a84
Compare
nrgnrg
force-pushed
the
feat/directory-mode
branch
from
fbc6a84 to
716e705
Compare
matthewp
approved these changes
Jul 26, 2022
|
@nrgnrg sorry for the late review. Would you mind rebasing with main? We can then get this in. |
nrgnrg
force-pushed
the
feat/directory-mode
branch
4 times, most recently
from
ea9cce4 to
6c05ac4
Compare
nrgnrg
force-pushed
the
feat/directory-mode
branch
from
6c05ac4 to
7e985f4
Compare
|
Very happy to see this change: I was actually just discussing the merits of |
natemoo-re
approved these changes
Aug 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cloudflare Pages has 2 different ways of deploying a worker, the default mode which looks for a
functionsfolder in the project root and anadvancedmode which uses a_worker.jsin thedistdirectory.Different frameworks have opted for different approaches: Sveltkit targets advanced mode where as SolidStart and Qwik both target the functions directory.
Advanced mode provides a more consistant experience for users since the entire project gets built into the
distfolder which is familiar. However the limitation of this is that pages plugins can't be used. As I see it a major use case for pages plugins is for enabling things like Sentry, especially in the absence of any logs on the pages platform right now.This change adds an option to the adaptor to enable uses to change the default
advanceddeploy mode to the functions folder model which would allow the use of pages plugins and middleware. This mode creates a new functions folder in the project root where users can add plugins.Testing
Docs
Updated readme