Fix expected types for Element in our JSX definitions #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4d13cf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
commented
Jul 18, 2022
| // This is an unfortunate use of `any`, but unfortunately we can't make a type that works for every framework | ||
| // without importing every single framework's types (which comes with its own set of problems). | ||
| // Using any isn't that bad here however as in Astro files the return type of a component isn't relevant in most cases | ||
| type Element = HTMLElement | any; |
There was a problem hiding this comment.
This is not really a change, previously since the AstroComponentFactory import didn't work, this always counted as HTMLElement | any. So this just brings back the previous (pre beta 72) behaviour
matthewp
approved these changes
Jul 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In a recent PR we fixed an import to
AstroComponentFactory, this had the side effect of making our expected type forElementtoo strict (due to TypeScript weirdness), which lead to users encountering errors when using JSX frameworksAlso, this PR fixes the JSX definitions not working properly in the monorepo (finally!)
Fix #3945
Testing
Tested manually, also ran the language-server test suite with this changes and everything passed
Docs
N/A