Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an alpine integration and update example #4406

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Aug 21, 2022

Changes

  • @Princesseuh and I had talked about this a while ago, but never got around to it.
  • This adds the new Alpine.js integration that should be good for most users.
  • This updates the framework-alpine example to use the new integration.
  • Helps to address feedback like this.

Testing

  • Tested manually.
  • Covered by existing smoke tests.

Docs

  • Integration README will be automatically pulled into docs site
  • Is there anything that I need to do to get this integration added to the integrations page of docs?
  • Is there anything that I need to do to get this integration added to the integrations catalog of www?

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2022

🦋 Changeset detected

Latest commit: 4dec898

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/alpinejs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) labels Aug 21, 2022
@matthewp matthewp merged commit 7310e8a into main Aug 22, 2022
@matthewp matthewp deleted the alpine-integration branch August 22, 2022 18:25
This was referenced Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants